Polish ResizableBox and convert it to TypeScript. #35062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Feature] UI Components
|
Size Change: +558 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
ZebulanStanphill
requested review from
ajitbohra and
chrisvanpatten
as code owners
sarayourfriend
requested changes
Oct 6, 2021
packages/components/src/resizable-box/resize-tooltip/styles/resize-tooltip.styles.js
Outdated
Show resolved
Hide resolved
ZebulanStanphill
force-pushed
the
add/resizable-box-types
branch
2 times, most recently
from
c929e00
to
c07f615
Compare
ZebulanStanphill
force-pushed
the
add/resizable-box-types
branch
from
c07f615
to
8d9bac7
Compare
Comment on lines
+10
to
+11
| import { Resizable } from 're-resizable'; | ||
| import type { ResizableProps } from 're-resizable'; |
There was a problem hiding this comment.
These can be combined into a single import I think?
Suggested change
| import { Resizable } from 're-resizable'; | |
| import type { ResizableProps } from 're-resizable'; | |
| import { Resizable, ResizableProps } from 're-resizable'; |
There was a problem hiding this comment.
That's what I did at first, but ESLint complained:
I don't really understand what the issue was, or if there even is an actual issue and not just an ESLint issue, but using import type worked. It looks like eslint-plugin-import is out-of-date (the version in Gutenberg's main package.json is 2.23.4, but the latest release is 2.24.2, so maybe that's the issue?
There was a problem hiding this comment.
Huh... that's weird. It seems like it's probably an eslint configuration issue with TypeScript 🤔 import/named is likely looking at the real JavaScript exports and ignoring the TS type exports (which would be in a separate .d.ts file for a compiled package).
There was a problem hiding this comment.
I figure it's not a blocker for merge, though, right?
sarayourfriend
approved these changes
Oct 13, 2021
Comment on lines
+10
to
+11
| import { Resizable } from 're-resizable'; | ||
| import type { ResizableProps } from 're-resizable'; |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR converts the
ResizableBoxcomponent to TypeScript and cleans some stuff up along the way.Part of #18838.
List of changes
ResizableBoxand its sub-components to TypeScript.ResizableBoxcomponent function so they aren't duplicated for every instance.nullproperties were included inReact.CSSPropertiesobjects, which expectundefinedfor empty values.resize-tooltip/styles/resize-tooltip.styles.js.strictNullChecksfor@wordpress/components. (Helped a lot in finding some of the above issues.)How has this been tested?
I inserted a Spacer block and used checked to make sure the drag handles work and display tooltips as before.
Checklist:
*.native.jsfiles for terms that need renaming or removal).