Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility improvement for font weight screen reader description #34312

Merged
merged 3 commits into from
Aug 26, 2021
Merged

Accessibility improvement for font weight screen reader description #34312

merged 3 commits into from
Aug 26, 2021

Conversation

alexstine
Copy link
Contributor

@alexstine alexstine commented Aug 26, 2021 •
edited
Loading

Description

Add a function for custom description for currently selected font weight.

How has this been tested?

Tested on Windows using NVDA in Chrome and Firefox.

Screenshots

Types of changes

Quick Bug fix/improvement.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@alexstine alexstine self-assigned this Aug 26, 2021
@alexstine alexstine added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility labels Aug 26, 2021
@alexstine
Copy link
Contributor Author

I believe this is going to be my first PR with tests that don't fail. Exciting. I believe I've got that pesky linter error fixed and this should be good to go once last test finishes. This is ready for code review.

aristath
aristath approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!
Code is clean, nothing breaks and the descriptions are a lot better now.
Thank you Alex!

@aristath aristath merged commit 8d1ea0a into WordPress:trunk Aug 26, 2021
@github-actions github-actions bot added this to the Gutenberg 11.5 milestone Aug 26, 2021
@alexstine alexstine deleted the fix/font-weight-accessibility branch August 26, 2021 18:04
@getsource getsource added [Package] Block editor /packages/block-editor [Type] Enhancement A suggestion for improvement. labels Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath aristath approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

@youknowriad youknowriad Awaiting requested review from youknowriad

@talldan talldan Awaiting requested review from talldan

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

Assignees

@alexstine alexstine

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Package] Block editor /packages/block-editor [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 11.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexstine @aristath @getsource