Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNMobile: Add integration test guide #33833

Merged
merged 5 commits into from
Aug 4, 2021

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Aug 3, 2021

Description

Adds a guide to integration tests on Gutenberg Mobile.

How has this been tested?

Read through the guide to ensure legibility and accuracy.

Types of changes

  • Updated docs

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

Co-authored-by: Carlos Garcia <[email protected]>
@guarani guarani added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Aug 3, 2021
@guarani guarani requested a review from fluiddot August 3, 2021 02:19
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the document and it looks great to me 🎊, I only added a couple of comments that are minor, thanks @guarani for adding the guide 🙇 !

@guarani
Copy link
Contributor Author

guarani commented Aug 4, 2021

@fluiddot, I've changed the document title 01b9e87, change the heading sizes and added a table of contents 6d90edd, and made the screenshot of the Accessibility Inspector a little wider for better readability 9917920.
It's now ready for a re-review.

@guarani guarani requested a review from fluiddot August 4, 2021 14:30
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

@fluiddot, I've changed the document title 01b9e87, change the heading sizes and added a table of contents 6d90edd, and made the screenshot of the Accessibility Inspector a little wider for better readability 9917920.
It's now ready for a re-review.

Thanks for the changes, I really liked the idea of the table of contents 💯 .

@guarani
Copy link
Contributor Author

guarani commented Aug 4, 2021

Thanks for all the work that went into the documentation! 👍

@guarani guarani merged commit 70c6a8a into trunk Aug 4, 2021
@guarani guarani deleted the rnmobile/add/integration-test-guide branch August 4, 2021 15:42
@github-actions github-actions bot added this to the Gutenberg 11.3 milestone Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants