data: Add types to redux-store/metadata/selectors #32965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
ciampo
approved these changes
Jun 25, 2021
According to the TypeScript introduction rules for the repository (documented here: https://make.wordpress.org/core/2021/04/09/follow-up-to-the-native-typescript-proposal/#block-0a331f4d-0e29-4de4-95c6-8be46f703394) we should only convert files to TypeScript when it's necessary for being able to type them. Otherwise we should leave them as the original JavaScript. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds types to the rest of
redux-store/metadata/selectorswhich finishesredux-store/metadata.Part of #18838
How has this been tested?
Type checks pass.
Types of changes
Only one runtime change is to explicitly
return undefinedinstead of justreturn;. This isn't really a runtime change 🤷Otherwise it's only updates to the JSDocs.
Checklist:
*.native.jsfiles for terms that need renaming or removal).