Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the update of link and suggestions in LinkControl #32320

Merged
merged 6 commits into from
Nov 5, 2021
Merged

Fix the update of link and suggestions in LinkControl #32320

merged 6 commits into from
Nov 5, 2021

Commits on Oct 28, 2021

  1. Fix the update of link and suggestions in LinkControl 

    When switching between two links, the LinkControl component does not unmount.
The value prop will change but the component does not react to this change and does
not show the updated link & suggestions.
    @ralucaStan
    ralucaStan committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    4c92945 View commit details
    Browse the repository at this point in the history

  2. Remove trim from function argument for updateSuggestions. 

    Trimming gets done in the function itself, since PR WordPress#35060.
    @ralucaStan
    ralucaStan committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    77bf651 View commit details
    Browse the repository at this point in the history

  3. Update packages/block-editor/src/components/url-input/index.js 

    Co-authored-by: Dave Smith <[email protected]>
    @ralucaStan @getdave
    ralucaStan and getdave committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    dfc3dd8 View commit details
    Browse the repository at this point in the history

  4. Take into consideration the case when the value changes with an empty… 

    … string

This was removed by the first commits, but we need to take into consideration that we also want to show the initial suggestions when the new value is empty
    @ralucaStan
    ralucaStan committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    33fe7b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. Merge branch 'WordPress:trunk' into fix/link-control-value-update

    @ralucaStan
    ralucaStan authored Nov 1, 2021
    Configuration menu
    Copy the full SHA
    34cf942 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2021

  1. Update packages/block-editor/src/components/url-input/index.js 

    Co-authored-by: Dave Smith <[email protected]>
    @ralucaStan @getdave
    ralucaStan and getdave authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    265ef2f View commit details
    Browse the repository at this point in the history