fix(RadioControl): checked style outside of Gutenberg #30670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvanpatten
added
[Feature] UI Components
|
Size Change: +14 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Apr 9, 2021
|
Thanks @jasmussen! Feels good to kick the tires on a PR again, even if only a small one 😄 |
|
The smaller, the better, in my experience! Thanks for the work! 👌 |
|
Thanks for this fix! We just noticed this helps resolve the same rendering issue with the |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When used outside of Gutenberg, the style for a selected radio button in a
RadioControldoes not work correctly:This is because the
::beforepseudo-element is depending on abox-sizing: inheritwhich is applied only if the radio is wrapped by a container with one of several class names:(Pictured left:
RadioControloutside of Gutenberg; Pictured right:RadioControlinside of Gutenberg.)Applying the
box-sizingproperty at the component level resolves the issue:Notably, the
CheckboxControlis unaffected by this issue because it uses a positioned SVG icon rather than drawing a shape in CSS.How has this been tested?
Visual test using component outside of Gutenberg
Screenshots
see above
Types of changes
scoped CSS change
Checklist:
*.native.jsfiles for terms that need renaming or removal).