Site Editor: prevent navigation panel focus when hidden #29600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @creativecoder! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
david-szabo97
approved these changes
Mar 8, 2021
vindl
approved these changes
Mar 11, 2021
| @@ -14,27 +14,18 @@ | |||
|
|
|||
| body.is-navigation-sidebar-open & { | |||
| display: flex; | |||
|
|
|||
| .edit-site-navigation-toggle__button { | |||
There was a problem hiding this comment.
I think something else changed since then that makes this override unnecessary. Here's what I see (using this branch)... looks like border is visible underneath the icon (at least to my eyes)
| Firefox | Safari | Chrome |
|---|---|---|
 |
 |
 |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the site editor navigation panel from the accessibility tree when hidden, so it can't receive keyboard focus.
Also removes an unneeded border from the toggle button to improve the slide animation.
Fixes #29536
How has this been tested?
Using the keyboard to navigate through the site editor header.
Screenshots
Keyboard navigation in header menu
Remove bottom border from navigation toggle when closing panel
Types of changes
Non-breaking change
Checklist:
I've included developer documentation if appropriate.(n/a)I've updated all React Native files affected by any refactorings/renamings in this PR.(n/a)