InputControl: Fix labelPosition rendering with new ui/flex component #29226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Size Change: +42 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
storybook/main.js
Outdated
| webpackFinal: async ( config ) => { | ||
| // Find the DefinePlugin | ||
| const plugin = config.plugins.find( | ||
| ( p ) => p.definitions?.[ 'process.env' ] |
There was a problem hiding this comment.
This is causing an error for me when I run storybook:dev:
[1] ERR! /Users/sara/projects/gutenberg/storybook/main.js:29
[1] ERR! ( p ) => p.definitions?.[ 'process.env' ]
[1] ERR! ^
[1] ERR!
[1] ERR! SyntaxError: Unexpected token '.'
[1] ERR! at wrapSafe (internal/modules/cjs/loader.js:915:16)
[1] ERR! at Module._compile (internal/modules/cjs/loader.js:963:27)
[1] ERR! at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
[1] ERR! at Module.load (internal/modules/cjs/loader.js:863:32)
[1] ERR! at Function.Module._load (internal/modules/cjs/loader.js:708:14)
[1] ERR! at Module.require (internal/modules/cjs/loader.js:887:19)
[1] ERR! at require (internal/modules/cjs/helpers.js:74:18)
There was a problem hiding this comment.
Interesting! It was fine for me. Lemme fix :)
sarayourfriend
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this update, the
InputControlcomponent was updated to fix thelabelPositionrendering.The issue was caused by how the previous vs. new ui/flex component rendered styles.
During the
ui/flexintegration, theinput-control/input-basewas flipped to use the__unstableVersionofnextfor Flex.Below is a screenshot of this working for the
SelectControlcomponent (from Storybook)Another adjustment was to Storybook itself. The webpack config was modified so that Storybook can correctly render components targeted/wrapped with "next" components.
This issue was recently discovered here:
#29159 (review)
How has this been tested?
Tested in local Storybook and in Gutenberg
labelPositionknob to another valueChecklist: