Create block: Add support for static assets #28038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Package] Create Block
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/create-block-assets-path
branch
from
e8a6bc5
to
edf7a8f
Compare
6 tasks
|
As commented in #27881 (comment), this is how it can be tested:
|
gziolo
force-pushed
the
update/create-block-assets-path
branch
2 times, most recently
from
7556831
to
e720a6d
Compare
|
@gziolo I tested it and the good news is that the file remained! The bad news is that it was modified. The otf file started with 39 thousand lines and ended with about 48k. These were the exact steps I took:
Now, I don't think the following will be helpful but it probably doesn't hurt to mention: |
|
@jessynd, thank you for publishing the updated package to npm. I should do it myself yesterday 😅 On the bright side, now I can use your template to do some testing. I can reproduce the issue so now I have a straightforward part for fixing it. |
|
I got it working with the The fix was super simple: 1e8d29a, haha |
gziolo
force-pushed
the
update/create-block-assets-path
branch
from
e720a6d
to
1e8d29a
Compare
|
Yay!!!! This is so exciting! I will test it again myself today. |
|
I'm super excited about this change in tandem with the changes to the default @jessynd, thank you a lot for your invaluable help to make it happen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #27881. The issue was described by @jessynd as follows:
This PR add support for handling static assets with the
assetsPathfield in the external template configuration.assetsPathThis setting is useful when your template scaffolds a block that uses static assets like images or fonts, which should not be processed. It provides the path pointing to the location where assets are located.
Example:
How has this been tested?
It requires a 3rd party template for testing. I tested locally with tweaking the local template, but we need to validate with a package published to npm as follows:
npx wp-create-block --template name-of-the-templateTypes of changes
New feature (non-breaking change which adds functionality).
Checklist: