-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create block: Allow to list npm dependencies to be installed in the template #27880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
e167500
to
0704856
Compare
Add to the template configuration `npmPackages` field. It allows to list npm packages that will be installed for the scaffolded project. Install WordPress dependencies used by `esnext` template during scaffolding process.
0704856
to
89d3625
Compare
mweichert
reviewed
Jan 12, 2021
@gziolo Can you tell me what the reasoning is for including the Is it for IntelliSense / better code completion? Or any other reason? :) Thanks in advance! |
Yes, you are correct:
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Create Block
/packages/create-block
[Type] New API
New API to be used by plugin developers or package users.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
npmDependencies
field. It allows listing npm packages that will be installed for the scaffolded project.esnext
template during the scaffolding process.How has this been tested?
npx wp-create-block
When wrong strings are provided for npm packages installation then the following message is printed: