Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compose: Add types (progressively) #27344

Closed
wants to merge 27 commits into from
Closed

Compose: Add types (progressively) #27344

wants to merge 27 commits into from

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Nov 27, 2020 •
edited
Loading

Description

part of #18838

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

This was referenced Jan 14, 2021
Closed
Closed
This was referenced Feb 22, 2021
Closed
Closed
sarayourfriend
sarayourfriend reviewed Feb 25, 2021
View reviewed changes
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we now have native TypeScript support... should we just be re-writing these in TypeScript? It's probably a lot easier to do iteratively (one PR per file/couple of files) and would yield better results in the end.

packages/compose/src/hooks/use-async-list/index.js
Comment on lines +98 to +109
/**
* @template R
* @typedef {import('react').ReducerState<R>} ReducerState
*/
/**
* @template R
* @typedef {import('react').ReducerAction<R>} ReducerAction
*/
/**
* @template D
* @typedef {import('react').Dispatch<D>} Dispatch
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these types?

@sirreal @sarayourfriend
Fix type (whoops!)
b065600 
Co-authored-by: sarayourfriend <[email protected]>
Base automatically changed from master to trunk March 1, 2021 15:44
@skorasaurus skorasaurus added the [Package] Compose /packages/compose label Nov 13, 2021
@sirreal sirreal closed this Apr 11, 2023
@sirreal sirreal deleted the add/types-compose-v2 branch April 11, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarayourfriend sarayourfriend sarayourfriend left review comments

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix will be requested when the pull request is marked ready for review ellatrix is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra will be requested when the pull request is marked ready for review ajitbohra is a code owner

Assignees
No one assigned
Labels
[Package] Compose /packages/compose
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirreal @sarayourfriend @skorasaurus