Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Block: Update the list of categories to pick from #26448

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Create Block: Update the list of categories to pick from #26448

merged 2 commits into from
Oct 29, 2020

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Oct 26, 2020 •
edited
Loading

Description

Closes #22848.
Follows-up #19279.

It's possible now to register blocks without providing the category. It became optional in #22280.

In addition to that, there is now a refined list of categories as of #19279:

  • Text
  • Media
  • Design
  • Widgets (Unchanged)
  • Embeds (Unchanged)
  • Reusable (Unchanged) – set only by the user using UI

How has this been tested?

Scaffold a block with npx wp-create-block, and activate it in WordPress 5.5.0 or higher. It should work as before. During the scaffolding process please make sure that only new categories are listed.

Types of changes

Breaking change for @wordpress/create-block as the minimum WordPress version required becomes now 5.5.0.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@gziolo gziolo requested a review from mkaz as a code owner October 26, 2020 09:41
@gziolo gziolo self-assigned this Oct 26, 2020
@gziolo gziolo added [Package] Create Block /packages/create-block [Type] Breaking Change For PRs that introduce a change that will break existing functionality labels Oct 26, 2020
@gziolo gziolo requested review from mcsf and mtias October 27, 2020 15:58
@gziolo
Copy link
Member Author

gziolo commented Oct 27, 2020

@mcsf or @mtias can I ask you for sanity check?

@gziolo gziolo merged commit 36d2e19 into master Oct 29, 2020
@gziolo gziolo deleted the update/create-block-categories branch October 29, 2020 08:26
@github-actions github-actions bot added this to the Gutenberg 9.3 milestone Oct 29, 2020
@mtias
Copy link
Member

mtias commented Oct 29, 2020

Looks good :)

gziolo added a commit that referenced this pull request Oct 30, 2020
@gziolo
Create Block: Update the list of categories to pick from (#26448)
8fde3b5 
* Create Block: Update the list of categories to pick from

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaz mkaz Awaiting requested review from mkaz

@mcsf mcsf Awaiting requested review from mcsf

@mtias mtias Awaiting requested review from mtias

Assignees

@gziolo gziolo

Labels
[Package] Create Block /packages/create-block [Type] Breaking Change For PRs that introduce a change that will break existing functionality
Projects
None yet
Milestone
Gutenberg 9.3
Development

Successfully merging this pull request may close these issues.

Create Block: Update the list of default categories to pick from after WordPress 5.5 is out
2 participants
@gziolo @mtias