Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Add navigation to link settings and add link picker screen to block settings #26206

Merged
merged 16 commits into from
Nov 12, 2020
Merged

[RNMobile] Add navigation to link settings and add link picker screen to block settings #26206

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
53d3f93
Add scrollable screens to bottom-sheet
dratwas Oct 16, 2020
e1d7d7d
rename withNavigation to hasNavigation
dratwas Oct 20, 2020
c1ad703
fix slider spacing
dratwas Oct 20, 2020
44c4990
add hasNavigation to the container.native
dratwas Oct 20, 2020
4d7ab3f
Merge branch 'master' into rnmobile/bottom-sheet-scrollable-screen
dratwas Oct 20, 2020
95c18c6
Merge branch 'master' into rnmobile/bottom-sheet-scrollable-screen
dratwas Nov 2, 2020
1a7ad30
Merge branch 'master' into rnmobile/bottom-sheet-scrollable-screen
dratwas Nov 2, 2020
d06c3e5
Add navigation to link settings and add link picker screen
dratwas Oct 16, 2020
e4c51a3
change withNavigation to the hasNavigation
dratwas Oct 20, 2020
0b3a196
Add "hasPicker" prop to the LinkSettings to determine if open link pi…
dratwas Nov 2, 2020
7d2b74d
refactor to less changes
dratwas Nov 2, 2020
1744cf4
Merge branch 'master' into rnmobile/settings-link-picker
dratwas Nov 3, 2020
3cdda64
Add changelog note
dratwas Nov 3, 2020
d053817
Merge branch 'master' into rnmobile/settings-link-picker
dratwas Nov 4, 2020
440211b
Merge branch 'master' into rnmobile/settings-link-picker
dratwas Nov 5, 2020
474a088
Merge branch 'master' into rnmobile/settings-link-picker
dratwas Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix slider spacing
  • Loading branch information
@dratwas
dratwas committed Oct 20, 2020
commit c1ad703cde6cf46a31566753ccdc67e9e0ccf4a2
1 change: 1 addition & 0 deletions packages/components/src/mobile/bottom-sheet/range-cell.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ class BottomSheetRangeCell extends Component {
activeOpacity={ 1 }
accessible={ accessible }
onPress={ this.onCellPress }
valueStyle={ styles.valueStyle }
accessibilityLabel={ accessibilityLabel }
accessibilityHint={
/* translators: accessibility text (hint for focusing a slider) */
Expand Down
4 changes: 4 additions & 0 deletions packages/components/src/mobile/bottom-sheet/range-cell.native.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,7 @@
padding-top: 8px;
padding-bottom: 8px;
}

.valueStyle {
height: 0;
}