Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile][iOS] Fix for toolbar when hiding keybord with cmd + k (external one) #25955

Merged
merged 1 commit into from
Oct 8, 2020
Merged

[RNMobile][iOS] Fix for toolbar when hiding keybord with cmd + k (external one) #25955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/components/src/mobile/keyboard-avoiding-view/index.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,14 @@ export const KeyboardAvoidingView = ( {
}

function onKeyboardWillHide( { duration, startCoordinates } ) {
// The startCoordinates.height is set to wrong value when we use cmd + k for hide the keyboard (Have no idea why).
// Because of that the `setIsKeyboardOpened` is not invoked and the state of keyboard is wrong.
// The keyboardIsOpenBreakpoint use 100 as a fallback if the startCoordinates.height is too small (cmd + k case)
const keyboardIsOpenBreakpoint =
startCoordinates.height > 100 ? startCoordinates.height / 3 : 100;
const animatedListenerId = animatedHeight.addListener(
( { value } ) => {
if ( value < startCoordinates.height / 3 ) {
if ( value < keyboardIsOpenBreakpoint ) {
setIsKeyboardOpen( false );
}
}
Expand Down