Navigation Component: Stop Updating the Active Menu on Active Item Change #25608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copons
added
[Type] Bug
Copons
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
6 tasks
|
Size Change: +1.38 kB (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
Copons
changed the base branch from
update/navigation-component-stories
to
master
Copons
changed the base branch from
master
to
update/navigation-component-stories
Copons
force-pushed
the
fix/navigation-component-active-root-menu
branch
from
5f1e0ab
to
b53543e
Compare
Copons
requested review from
ellatrix,
mkaz,
nerrad,
ntwb,
Soean,
spacedmonkey,
talldan and
TimothyBJacobs
as code owners
Copons
changed the base branch from
update/navigation-component-stories
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Navigationcomponents withactiveMenucontrolled externally butactiveMenuinternally, can't activate items in nested menus.This is caused by the
useEffectthat attempt to sync theactiveMenubetween internal and external state, being triggered onactiveItemchange.If the external
activeMenuis not provided, it defaults toROOT_MENUand never changes.So, when we activate an item in a nested menu, we trigger that
useEffect, which checks if the internalmenuis not in sync with the externalactiveMenu, and updates the former with the latter.Since the external
activeMenuis alwaysROOT_MENU, every time we activate an item in a nested menu, we accidentally activateROOT_MENU.The fix
Just remove
activeItemfrom thatuseEffectdependencies.This way, the active menu will only be syncd when the external
activeMenuchanges, which means that it's externally controlled, which is the only case we need to sync it.How has this been tested?
npm run storybook:devI've set the base for this PR on
update/navigation-component-stories(#25572), which is where I've noticed this issue, to make it easier to test.Once approved, I'll merge this on master.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: