Add aria-haspopup attribute to CustomGradientBar component #25571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
oandregal
added
the
[Focus] Accessibility (a11y)
|
Size Change: +12 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
oandregal
commented
Sep 23, 2020
| @@ -105,6 +105,7 @@ function ControlPointButton( { | |||
| color | |||
| ) } | |||
| aria-describedby={ descriptionId } | |||
| aria-haspopup="true" | |||
There was a problem hiding this comment.
I've chosen true as value instead of a more concrete one because 1) it's still valid as of ARIA 1.1 and 2) all the cases in which aria-haspopup is present we used this value so far. Happy to set it to a different value.
There was a problem hiding this comment.
true sounds fair to me, I can't see a better option.
tellyworth
approved these changes
Sep 24, 2020
| @@ -105,6 +105,7 @@ function ControlPointButton( { | |||
| color | |||
| ) } | |||
| aria-describedby={ descriptionId } | |||
| aria-haspopup="true" | |||
There was a problem hiding this comment.
true sounds fair to me, I can't see a better option.
|
Screenshot for history 👍
Testing with Safari + VoiceOver: the gradient picker buttons are announced has having a "menu pop-up", indicating they open an additional UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
aria-haspopupproperty to the CustomGradientBar component. See #24796 for a detailed explanation.