Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] Create endpoint to post notices from host apps #25266

Merged
merged 3 commits into from
Oct 2, 2020
Merged

[Mobile] Create endpoint to post notices from host apps #25266

merged 3 commits into from
Oct 2, 2020

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Sep 11, 2020 •
edited
Loading

Fixes: wordpress-mobile/gutenberg-mobile#2453

Related PRs:
gutenberg-mobile wordpress-mobile/gutenberg-mobile#2613
WordPress-iOS wordpress-mobile/WordPress-iOS#14886

Description

Adds an api that the host apps can use to present the info notice. This is being used as part of wordpress-mobile/gutenberg-mobile#2453 to show the page created messages.
🗒️ The linked PRs cover the iOS version of this feature. @antonis will be working on the Android side in a later PR.

How has this been tested?

🗒️ Test cases here are taken from wordpress-mobile/WordPress-iOS#14886

To disable or enable the development version of Modal Layout Picker
  • Open the app from the build that allows FeatureFlags such as a PR build or a local development build
    • By default, the modal layout picker will be disabled.
    • From the site page:
      • Click on your Gravatar.
      • Click on App Settings.
      • Click on Debug.
      • Toggle "Gutenberg Modal Layout Picker" to enable or disable the picker

When enabled, the Layout Picker should show when creating a new page from My Site and from the Page list.

Start by navigating to the Modal Layout Picker

Page Created (with content)

  1. Select a Layout from the options in Modal Layout Picker
  2. Select "Create Page"
    Expect to see the info notice banner appear under the navigation bar with the text "Page created"
  • 🗒️ This is different than the mocks in the linked issue but aligns with the direction that was determined.

Blank Page Created

  1. Select "Create Blank Page"
    Expect to see the info notice banner appear under the navigation bar with the text "Blank page created"
  • 🗒️ This is different than the mocks in the linked issue but aligns with the direction that was determined.

Blog Post Created

  1. Create a new blog post
  • This should not display the notice bar

Open existing Page Created

  1. Open an existing page (either published or draft)
  • This should not display the notice bar

Disable Modal Layout Picker

  1. Create a new page
  • This should not display the notice bar

Screenshots

Create Page Create Blank Page Clip

Types of changes

Enhancement

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@chipsnyder chipsnyder added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Sep 11, 2020
@chipsnyder chipsnyder added this to In progress in Mobile Apps via automation Sep 11, 2020
This was referenced Sep 11, 2020
Merged
Merged
@chipsnyder chipsnyder requested a review from Tug September 11, 2020 20:58
@chipsnyder chipsnyder marked this pull request as ready for review September 11, 2020 20:58
@github-actions
Copy link

github-actions bot commented Sep 11, 2020 •
edited
Loading

Size Change: +70 B (0%)

Total Size: 1.17 MB

Filename Size Change
build/edit-post/style-rtl.css 6.25 kB +10 B (0%)
build/edit-post/style.css 6.24 kB +10 B (0%)
build/editor/style-rtl.css 3.83 kB +26 B (0%)
build/editor/style.css 3.82 kB +24 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.52 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 8.53 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 128 kB 0 B
build/block-editor/style-rtl.css 11.1 kB 0 B
build/block-editor/style.css 11.1 kB 0 B
build/block-library/editor-rtl.css 8.6 kB 0 B
build/block-library/editor.css 8.6 kB 0 B
build/block-library/index.js 135 kB 0 B
build/block-library/style-rtl.css 7.61 kB 0 B
build/block-library/style.css 7.6 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.78 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.5 kB 0 B
build/components/index.js 167 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 9.42 kB 0 B
build/core-data/index.js 12 kB 0 B
build/data-controls/index.js 1.27 kB 0 B
build/data/index.js 8.43 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.42 kB 0 B
build/edit-navigation/index.js 10.4 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-site/index.js 20.3 kB 0 B
build/edit-site/style-rtl.css 3.51 kB 0 B
build/edit-site/style.css 3.51 kB 0 B
build/edit-widgets/index.js 17.5 kB 0 B
build/edit-widgets/style-rtl.css 2.8 kB 0 B
build/edit-widgets/style.css 2.8 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/index.js 45.5 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.55 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.34 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.7 kB 0 B
build/server-side-render/index.js 2.61 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.74 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

Tug
Tug reviewed Sep 25, 2020
View reviewed changes
Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I have not product reviewed the whole PR chain.

Could you open an issue in gutenberg mobile to have feature parity for android related to this change?

@chipsnyder
Copy link
Contributor Author

Could you open an issue in gutenberg mobile to have feature parity for android related to this change?

For the Mobile Layout Picker work, we've just left a single issue open until both the iOS and Android side gets implemented.

@Tug
Copy link
Contributor

Tug commented Sep 25, 2020

For the Mobile Layout Picker work, we've just left a single issue open until both the iOS and Android side gets implemented.

Perfect then!

geriux
geriux approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested all cases on an iPhone 11 Pro Max and iPad 7.

Nice work @chipsnyder!

@chipsnyder chipsnyder merged commit f31a260 into master Oct 2, 2020
Mobile Apps automation moved this from In progress to Done Oct 2, 2020
@chipsnyder chipsnyder deleted the mobile/issue/2453-toast branch October 2, 2020 14:45
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Oct 2, 2020
@antonis antonis mentioned this pull request Oct 8, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tug Tug Tug left review comments

@geriux geriux geriux approved these changes

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
Mobile Apps
  
Done
Milestone
Gutenberg 9.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chipsnyder @Tug @geriux