[RNMobile] Fix for vertical alignment in column that is added from the inserter menu. #24656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
2 tasks
|
Hey @chipsnyder could you please check this PR? cc: @cameronvoell Please cherry-pick this PR to the release branch as well. |
chipsnyder
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Tested and it's working as expected. Thanks for the quick fix @dratwas
This was referenced Aug 19, 2020
cameronvoell
pushed a commit
that referenced
this pull request
Aug 19, 2020
…e inserter menu (#24656)
cameronvoell
added a commit
that referenced
this pull request
Aug 25, 2020
* Release script: Update react-native-editor version to 1.35.0 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Fix for vertical alignment in column that is added from the inserter menu (#24656) Co-authored-by: Drapich Piotr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: wordpress-mobile/WordPress-Android#12709 (comment)
GB-mobile PR: wordpress-mobile/gutenberg-mobile#2560
When the column block is added by the appender then we set the alignment while creating a new
columnblock (https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/columns/edit.native.js#L326). Unfortunately the alignment is not set when we add the column from inserter menu.In this PR I set the alignment from the parent (
columns) if no alignment is set in the block (column).I added a
useEffectwith no dependencies to do it only after the component is mounted and theverticalAlignmentis not set in the column block.How has this been tested?
Screenshots
Types of changes
Fix for vertical alignment in the column that is added from the inserter menu.
Checklist: