[RNMobile] Turn off autosave interval for mobile #24415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +42 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
adamziel
approved these changes
Aug 6, 2020
|
I did not test in the actual android app, but it seems to work in the browser if I set the prop manually. The code makes sense too - thank you! |
lukewalczak
approved these changes
Aug 7, 2020
cameronvoell
pushed a commit
that referenced
this pull request
Aug 7, 2020
5 tasks
cameronvoell
added a commit
that referenced
this pull request
Aug 11, 2020
* Release script: Update react-native-editor version to 1.34.0 * [RNMobile] E2E Android - Use swipe gesture to scroll inserter menu (#24338) * Set autosaveInterval to 1 on mobile (#24353) * Revert "[RNMobile] Fix jumping toolbar (#23684)" (#24388) This reverts commit d86cd5f. * Turn off autosave interval for mobile (#24415) * [RNMobile] Merge release 1.33.1 to master (#24448) * Release script: Update react-native-editor version to 1.33.0 * Update release notes. * Update version numbers for packages. * Revert "Reduce spacing between label and slider control (#23580)" (#24109) This reverts commit 2a67de0. * Release script: Update react-native-* versions to 1.33.1 * Release script: Update with changes from 'npm run core preios' * Allow @ char in posts in mobile editor (#24428) This fixes a bug with the @-mention feature on mobile that made entering the standalone @ character difficult because of the @-mention UI getting in the way. The fix here is to allow the @ character to be intercepted without being consumed by the @ key event logic. * Remove duplicate entry from changelog Co-authored-by: Sergio Estevao <[email protected]> Co-authored-by: Antonis Lilis <[email protected]> Co-authored-by: Ceyhun Ozugur <[email protected]> Co-authored-by: Paul Von Schrottky <[email protected]> * Update version numbers * Ran pod install to update podfile.lock Co-authored-by: Drapich Piotr <[email protected]> Co-authored-by: Adam Zielinski <[email protected]> Co-authored-by: Chip <[email protected]> Co-authored-by: Cameron Voell <[email protected]> Co-authored-by: Sergio Estevao <[email protected]> Co-authored-by: Antonis Lilis <[email protected]> Co-authored-by: Paul Von Schrottky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Autosave mechanism was changed recently and sets the interval to check if there are new changes to save. It works well for the web but introduced some issues on mobile. we used to call
autosaveafter each change and the native part has an own throttle mechanism to handle that in a performant way.In this PR I added a prop called
disableIntervalChecksthat determines if the interval should be set. I set this to true for mobile autosave in the layout component.How has this been tested?
The autosave should work the same for web
The autosave is called after each change on mobile
Types of changes
Remove unnecessary interval on mobile.
Checklist: