Update code owners for rich text native implementations #24216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioEstevao
added
the
Mobile App - i.e. Android or iOS
SergioEstevao
requested review from
karmatosed,
mapk and
youknowriad
as code owners
|
Size Change: -1.03 MB (89%) 🏆 Total Size: 1.16 MB
ℹ️ View Unchanged
|
|
SGTM 👍 |
hypest
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
LGTM! Eduardo, Cameron and Paul will be the "native RichText representatives" at this stage.
@SergioEstevao , please check-off the items in the checklist before merging, thanks!
Also, see my comment about the order of mentions, thanks!
hypest
reviewed
Jul 28, 2020
.github/CODEOWNERS
Outdated
| /packages/format-library @ellatrix @daniloercoli @sergioestevao @etoledom | ||
| /packages/rich-text @ellatrix @daniloercoli @sergioestevao @etoledom | ||
| /packages/block-editor/src/components/rich-text @ellatrix @daniloercoli @sergioestevao @etoledom | ||
| /packages/format-library @ellatrix @etoledom @guarani @cameronvoell |
There was a problem hiding this comment.
@SergioEstevao , can you actually put Cameron as the third contact in the list, so we can have better platform coverage (Eduardo is primarily iOS and Cameron is primarily Android) when people read through that list?
…, Android, iOS(2nd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the code owners for the rich text components.
Going forward beside @etoledom, @cameronvoell and @guarani will keep an eye on the rich text components from a RN perspective.
How has this been tested?
Screenshots
Types of changes
Checklist: