Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quote left border color in dark mode. #23692

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Fix quote left border color in dark mode. #23692

merged 1 commit into from
Jul 6, 2020

Conversation

SergioEstevao
Copy link
Contributor

Description

Restored the styles on the quote block for the RN implementation to support correctly dark and light modes.

How has this been tested?

Screenshots

Before After

Types of changes

Bugfix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@SergioEstevao SergioEstevao added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jul 3, 2020
@SergioEstevao SergioEstevao requested review from Tug and ceyhun July 3, 2020 21:15
@github-actions
Copy link

github-actions bot commented Jul 3, 2020

Size Change: 0 B

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.48 kB 0 B
build/block-directory/style-rtl.css 944 B 0 B
build/block-directory/style.css 945 B 0 B
build/block-editor/index.js 109 kB 0 B
build/block-editor/style-rtl.css 10.7 kB 0 B
build/block-editor/style.css 10.7 kB 0 B
build/block-library/editor-rtl.css 7.57 kB 0 B
build/block-library/editor.css 7.57 kB 0 B
build/block-library/index.js 130 kB 0 B
build/block-library/style-rtl.css 7.78 kB 0 B
build/block-library/style.css 7.79 kB 0 B
build/block-library/theme-rtl.css 728 B 0 B
build/block-library/theme.css 729 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.2 kB 0 B
build/components/index.js 198 kB 0 B
build/components/style-rtl.css 15.8 kB 0 B
build/components/style.css 15.8 kB 0 B
build/compose/index.js 9.65 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.44 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.19 kB 0 B
build/edit-navigation/index.js 9.98 kB 0 B
build/edit-navigation/style-rtl.css 1.02 kB 0 B
build/edit-navigation/style.css 1.02 kB 0 B
build/edit-post/index.js 304 kB 0 B
build/edit-post/style-rtl.css 5.57 kB 0 B
build/edit-post/style.css 5.57 kB 0 B
build/edit-site/index.js 16.6 kB 0 B
build/edit-site/style-rtl.css 3.03 kB 0 B
build/edit-site/style.css 3.03 kB 0 B
build/edit-widgets/index.js 9.32 kB 0 B
build/edit-widgets/style-rtl.css 2.45 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/index.js 44.8 kB 0 B
build/editor/style-rtl.css 3.78 kB 0 B
build/editor/style.css 3.77 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.73 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.3 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.41 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 788 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

pinarol
pinarol approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, working well on iOS:

@SergioEstevao SergioEstevao requested a review from geriux July 6, 2020 10:04
@geriux
Copy link
Member

geriux commented Jul 6, 2020

LGTM! Working well on Android as well.

@SergioEstevao SergioEstevao merged commit f47037a into master Jul 6, 2020
@SergioEstevao SergioEstevao deleted the rnmobile/fix_quote_color_in_dark_mode branch July 6, 2020 10:18
@github-actions github-actions bot added this to the Gutenberg 8.5 milestone Jul 6, 2020
SergioEstevao added a commit that referenced this pull request Jul 6, 2020
@SergioEstevao
Fix quote left border color in dark mode. (#23692)
398254a
SergioEstevao added a commit that referenced this pull request Jul 8, 2020
@mchowning @guarani
@marecar3 @lukewalczak @SergioEstevao @cameronvoell
Merge rnmobile 1.31.1 to master (#23772)
7dee942 
* Run pod install in react-native-editor/ios/

* [RN-MOBILE] fix line height crash (#23507)

* Fix line-height crash

* format fix

* Add block example with lineHeight attribute

* [RNMobile] Correct Buttons block width (#23616)

* Fix quote left border color in dark mode. (#23692)

* Update react-native-editor package and release notes.

* Fix translations for media options

* Load block-library lazily after translations occur to fix names of blocks in inserter.

* lint fixes

* Merge master branch to merge_rnmobile_1.31.1_to_master

Co-authored-by: Paul Von Schrottky <[email protected]>
Co-authored-by: Marko Savic <[email protected]>
Co-authored-by: Luke Walczak <[email protected]>
Co-authored-by: Sérgio Estêvão <[email protected]>
Co-authored-by: Cameron Voell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

@Tug Tug Awaiting requested review from Tug

@ceyhun ceyhun Awaiting requested review from ceyhun

@geriux geriux Awaiting requested review from geriux

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 8.5
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioEstevao @geriux @pinarol