Create Block: Fix errors reported by CSS linter in ESNext template #23188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Package] Create Block
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
ocean90
approved these changes
Jun 16, 2020
You are reading my mind, I'm refactoring Create Block to make installation of npm i
npx wp-create-block esnext-test --no-wp-scripts
cd esnext-test
../node_modules/.bin/wp-scripts format-js
../node_modules/.bin/wp-scripts lint-js
../node_modules/.bin/wp-scripts lint-css
../node_modules/.bin/wp-scripts buildI'm proposing the usage of the Gutenberg local packages here to ensure that scaffolded block works with the recent version of all WordPress packages, not the one published to npm Yet another step to ensure everything works as intended would be to scaffold the block and run e2e test that inserts it into the editor. |
|
Now, I have #23195 opened which proposes integration testing. I still want to find a way to run it standalone in the local environment. |
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running the command for linting CSS in the scaffolded block I see the following errors reported:
This PR fixes those issues by using hex values.
How has this been tested?
$ npx wp-create-block my-test-block $ cd my-test-block $ npm run lint:cssFollow-up task
We really need some CI integration that would ensure that those scripts in scaffolded blocks pass :)