Send contentInfo information when updating HTML. #23115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioEstevao
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
2 tasks
hypest
reviewed
Jun 16, 2020
hypest
approved these changes
Jun 16, 2020
There was a problem hiding this comment.
LGTM @SergioEstevao ! I've only left one comment but I don't consider it blocking for the PR.
hypest
reviewed
Jun 16, 2020
| @@ -252,7 +252,7 @@ export default compose( [ | |||
| title: getEditedPostAttribute( 'title' ), | |||
| getEditedPostContent, | |||
| selectedBlockIndex: getBlockIndex( selectedBlockClientId ), | |||
| blockCount: getBlockCount( rootClientId ), | |||
| blockCount: getGlobalBlockCount(), | |||
There was a problem hiding this comment.
Looks like getBlockCount is not needed anymore and we can remove it from the extraction list above, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send content structure information to the native apps for them to be able to display it.
How has this been tested?
This can be tested using the GB-mobile PR here: wordpress-mobile/gutenberg-mobile#2380
Screenshots
Types of changes
Checklist: