Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of gradient hooks #23058

Merged
merged 6 commits into from
Jun 10, 2020
Merged

Fix use of gradient hooks #23058

merged 6 commits into from
Jun 10, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jun 10, 2020 •
edited
Loading

Description

Change the way we use the useGradient methods on the RN Button to use an HOC withGradient.

This was done because before we were using useGradient that is a hook on a non function component and we were seeing crashes after media insertion.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@SergioEstevao SergioEstevao added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jun 10, 2020
@github-actions
Copy link

github-actions bot commented Jun 10, 2020 •
edited
Loading

Size Change: +2.09 kB (0%)

Total Size: 1.13 MB

Filename Size Change
build/block-editor/index.js 106 kB +14 B (0%)
build/block-library/index.js 129 kB +1.6 kB (1%)
build/block-library/style-rtl.css 7.96 kB +238 B (2%)
build/block-library/style.css 7.96 kB +237 B (2%)
build/components/style-rtl.css 19.5 kB -7 B (0%)
build/components/style.css 19.5 kB -4 B (0%)
build/editor/index.js 44.8 kB +9 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.77 kB 0 B
build/block-directory/style-rtl.css 892 B 0 B
build/block-directory/style.css 892 B 0 B
build/block-editor/style-rtl.css 12.1 kB 0 B
build/block-editor/style.css 12.1 kB 0 B
build/block-library/editor-rtl.css 7.88 kB 0 B
build/block-library/editor.css 7.89 kB 0 B
build/block-library/theme-rtl.css 684 B 0 B
build/block-library/theme.css 686 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 195 kB 0 B
build/compose/index.js 9.31 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.44 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.17 kB 0 B
build/edit-navigation/index.js 8.26 kB 0 B
build/edit-navigation/style-rtl.css 975 B 0 B
build/edit-navigation/style.css 974 B 0 B
build/edit-post/index.js 303 kB 0 B
build/edit-post/style-rtl.css 5.6 kB 0 B
build/edit-post/style.css 5.6 kB 0 B
build/edit-site/index.js 16.6 kB 0 B
build/edit-site/style-rtl.css 2.96 kB 0 B
build/edit-site/style.css 2.96 kB 0 B
build/edit-widgets/index.js 9.34 kB 0 B
build/edit-widgets/style-rtl.css 2.4 kB 0 B
build/edit-widgets/style.css 2.4 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/editor/style-rtl.css 4.26 kB 0 B
build/editor/style.css 4.27 kB 0 B
build/element/index.js 4.64 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.72 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14.8 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@SergioEstevao SergioEstevao changed the title Fix way prop insertBlockAfter is send. Fix use of gradient hooks Jun 10, 2020
geriux
geriux approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested it using Starter page templates, standard posts with the Buttons block. Also checked on the local instance of web and all good!

dratwas
dratwas approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@dratwas dratwas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @SergioEstevao!
Left one small comment :)

Tested on iOS with the gallery, image, and video blocks - everything works perfectly! 🎉

@SergioEstevao SergioEstevao merged commit c711a16 into master Jun 10, 2020
@SergioEstevao SergioEstevao deleted the rnmobile/fix_caption_break branch June 10, 2020 20:20
@github-actions github-actions bot added this to the Gutenberg 8.4 milestone Jun 10, 2020
SergioEstevao added a commit that referenced this pull request Jun 10, 2020
@SergioEstevao
Fix use of gradient hooks (#23058)
71b7266 
* Fix way prop insertBlockAfter is send.

* Use HOC to wrap around gradient hook.

* Improve gradient HOC to be more generic.

* Revert "Fix way prop insertBlockAfter is send."

This reverts commit e0d921d.

* Make withGradient available to RN libs.

* Move export of withGradient to the gradient folder.
This was referenced Jun 10, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol left review comments

@geriux geriux geriux approved these changes

@dratwas dratwas dratwas approved these changes

@mkevins mkevins Awaiting requested review from mkevins

@ellatrix ellatrix Awaiting requested review from ellatrix

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 8.4
Development

Successfully merging this pull request may close these issues.
4 participants
@SergioEstevao @geriux @pinarol @dratwas