Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: Add rich image editing option to experiments page #22870

Merged

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Jun 3, 2020

Description

As per discussion in #21024 (comment), this moves rich image editing to be an option which needs to be enabled by the user.

How has this been tested?

Run without the setting enabled and see that image editing tools are not shown.

Go to Gutenberg > Experiments and check "Enable Inline Rich Image Editing" and see that the image editing tools are shown.

Screenshots

rich image setting

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ajlende ajlende self-assigned this Jun 3, 2020
@ajlende ajlende added [Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media REST API Interaction Related to REST API [Type] Experimental Experimental feature or API. labels Jun 3, 2020
@jasmussen
Copy link
Contributor

Thanks Alex. I discovered a small issue with the image tools yesterday where selecting an image sets focus on the caption, and I needed to test some things where that issue wasn't present, so I merged this branch into my other branch, and it appears to correctly disable the image tools.

So for what it's worth, to me it seems worth it to keep Image tools merged, but disabled behind the experimental box. It allows us to fix the issues while still making it possible for users to discover issues in an easier way than checking out a PR.

Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you! Let's aim to unmark it as experimental by the next Gutenberg release.

@ellatrix ellatrix merged commit 7d1963f into WordPress:master Jun 8, 2020
@github-actions github-actions bot added this to the Gutenberg 8.3 milestone Jun 8, 2020
@ajlende ajlende deleted the fix/rich-image-experiments-setting branch June 8, 2020 18:40
@ellatrix ellatrix mentioned this pull request Jun 16, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media REST API Interaction Related to REST API [Type] Experimental Experimental feature or API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants