Fix skipped shortcode transforms in raw handling #22840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test for this? :) |
|
@ellatrix The test case has been added. I think I found the right place for it, but I'm new to contributing here so please let me know if I've missed something. 🙂 |
apmatthews
force-pushed
the
fix/shortcode-transforms
branch
from
c341d02
to
3aa23a6
Compare
apmatthews
force-pushed
the
fix/shortcode-transforms
branch
from
3aa23a6
to
69f5fc1
Compare
|
It doesn't seem like the test failures are related to this PR. I rebased on Anything else I can do help this land in WP 5.6? |
mcsf
approved these changes
Oct 19, 2020
|
Thanks for the fix, @apmatthews! This should make its way into 5.6. :) |
github-actions
bot
added
the
First-time Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22837
Description
Changes the shortcode converter in
rawHandler()to allow non-linear shortcode replacement while segmenting an HTML string. This prevents the priority or registration order of a transform from affecting how shortcodes are parsed out of HTML and into blocks.I'd appreciate feedback on whether this might have unintended consequences or if there was a reason it was not done before.
How has this been tested?
I've tested locally with the example outlined in #22837, but someone more familiar with the codebase should definitely take a look.Integration test case has been included.
Checklist: