[RNMobile] Fix footer appender in buttons block #22711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
lukewalczak
reviewed
May 28, 2020
2 tasks
|
Tested on both platforms and looks like problem is fixed! Thanks @dratwas |
lukewalczak
approved these changes
May 28, 2020
6 tasks
5 tasks
SergioEstevao
pushed a commit
that referenced
this pull request
May 29, 2020
* add renderFooterAppender to the extraData to re-render list * small refactor
mchowning
added a commit
that referenced
this pull request
Jun 1, 2020
* Remove Keyboard.dismiss() when deleting block * Move selection to end of link after insertion. (#22652) Make sure the selection is refreshed after changed. * Only show pullquote block on iOS. * Allow pullquote block to show on Android Dev builds * Change indentifier type in Button, correct concatenation in merge function (#22708) * [RNMobile] Fix footer appender in buttons block (#22711) * add renderFooterAppender to the extraData to re-render list * small refactor * Add onDeleteBlock to the extra data to re-render when it has changes (#22716) * add renderFooterAppender to the extraData to re-render list * small refactor * Add onDeleteBlock to the extra data to re-render when it has changes * add renderFooterAppender to the extraData to re-render list * small refactor * Add onDeleteBlock to the extra data to re-render when it has changes * [RNMobile] Correct color selection in color settings (#22736) * [RNMobile] Fix: Add default value to format when start and end are undefined (#22741) * add default vale to format when start and end are undefined * revert lint changes * Fix lint issue Co-authored-by: lukewalczak <[email protected]> Co-authored-by: Sérgio Estêvão <[email protected]> Co-authored-by: Drapich Piotr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2331
In this PR i fixed the issue with the appender in Buttons block. Since the FooterComponent od flatList is a pure component the list didn't re-render when props of block-list have changed. I added a
renderFooterAppenderfunction to the extra data and saved the extraData to a class property to not pass a new reference on every render. I also had to adduseRefin thebuttons/edit.native.jsto not create the function on every render which was forcing to re-render of the whole list.See wordpress-mobile/gutenberg-mobile#2321 (comment)
In addition, I fixed one small issue with padding in the link settings of the button block.
How has this been tested?
Screenshots
Types of changes
Fix of buttons appender
Checklist: