Stop checking for active formats when doing delete. #22446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the web this checking the active formats makes sense because you
have a mode where you are inside a selection ("active selection").
That doesn't happen on mobile so having a selection active shouldn't
block the deletion and merge.
SergioEstevao
added
the
Mobile App - i.e. Android or iOS
SergioEstevao
commented
May 18, 2020
| @@ -334,7 +333,6 @@ export class RichText extends Component { | |||
| if ( | |||
| ! onDelete || | |||
| ! isCollapsed( value ) || | |||
| activeFormats.length || | |||
There was a problem hiding this comment.
On the web this checking the active formats makes sense because you
have a mode where you are inside a selection ("active selection").
That doesn't happen on mobile so having a selection active shouldn't
block the deletion and merge.
There was a problem hiding this comment.
Your explanation was helpful for understanding the fix. Nice one!
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
cameronvoell
approved these changes
May 20, 2020
There was a problem hiding this comment.
Tested in the example app on Android and iOS. Didn't see any side effects and it looks like it solves wordpress-mobile/gutenberg-mobile#1873 . Well done! 🎉
| @@ -334,7 +333,6 @@ export class RichText extends Component { | |||
| if ( | |||
| ! onDelete || | |||
| ! isCollapsed( value ) || | |||
| activeFormats.length || | |||
There was a problem hiding this comment.
Your explanation was helpful for understanding the fix. Nice one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the web this checking the active formats makes sense because you
have a mode where you are inside a selection ("active selection").
That doesn't happen on mobile so having a selection active shouldn't
block the deletion and merge.
Description
How has this been tested?
This can be tested using this GB-mobile PR.
Screenshots
Types of changes
Bugfix for this issue: wordpress-mobile/gutenberg-mobile#1873
Checklist: