Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 331/mention support on @ keypress #22119

Merged
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
e10e226
Add '@' button for inserting mentions on mobile
mchowning Apr 15, 2020
e519b00
Merge branch 'master' into rnmobile/issue_331/mention_support
SergioEstevao Apr 20, 2020
f9b8548
Move react-native-azted dependency to external dependencies section
mchowning Apr 20, 2020
17f3196
Merge branch 'master' into rnmobile/issue_331/mention_support
SergioEstevao Apr 21, 2020
c862074
Handle promise rejection.
SergioEstevao Apr 21, 2020
f42daee
Fix focus issue.
SergioEstevao Apr 21, 2020
31da259
Add space after mention
SergioEstevao Apr 22, 2020
7ecbb7c
Update selection onFocus.
SergioEstevao Apr 23, 2020
cbb14e4
Merge branch 'master' into rnmobile/issue_331/mention_support
SergioEstevao Apr 24, 2020
4877a9b
Check for site capabilities for mentions support
SergioEstevao Apr 24, 2020
30052c6
Merge branch 'rnmobile/release-1.27.0' into rnmobile/issue_331/mentio…
SergioEstevao Apr 27, 2020
a833d4b
Add the mention button inside a toolbar.
SergioEstevao Apr 27, 2020
3487ffc
Use HOC for site capabilities.
SergioEstevao Apr 27, 2020
aa52210
Merge branch 'master' into rnmobile/issue_331/mention_support
SergioEstevao Apr 28, 2020
c968ab7
Only include space after mention on iOS
mchowning Apr 28, 2020
b737677
Merge branch 'master' into rnmobile/issue_331/mention_support
SergioEstevao Apr 30, 2020
7f3cee1
Use onKeyDown instead of onEnter and onBackspace.
SergioEstevao May 5, 2020
2fd1dfd
Intercept @ keypress to trigger mention UI.
SergioEstevao May 5, 2020
46665ab
Intercept @ keypress to trigger mention UI.
SergioEstevao May 5, 2020
0ec60af
Trigger the UI for mentions only when there is a space before the @
SergioEstevao May 6, 2020
94568a8
Put mentions behind the DEV flag.
SergioEstevao May 8, 2020
29d5f68
Merge branch 'rnmobile/issue_331/mention_support' into rnmobile/issue…
SergioEstevao May 8, 2020
0b76315
Only trigger @ keypress on DEV builds.
SergioEstevao May 8, 2020
e86a5a6
Merge branch 'rnmobile/stable' into rnmobile/issue_331/mention_support
SergioEstevao May 8, 2020
5492f4f
Merge branch 'rnmobile/issue_331/mention_support' into rnmobile/issue…
SergioEstevao May 8, 2020
d908f90
Remove DEV flag
SergioEstevao May 8, 2020
8a825c3
Only make mention keypress available when capabilities and editing me…
SergioEstevao May 9, 2020
884dc63
Merge branch 'rnmobile/release-1.28.0' into rnmobile/issue_331/mentio…
SergioEstevao May 11, 2020
e26a93b
Merge branch 'rnmobile/issue_331/mention_support' into rnmobile/issue…
SergioEstevao May 11, 2020
bc0770d
Merge branch 'master' into rnmobile/issue_331/mention_support_trigger…
SergioEstevao May 20, 2020
cd41576
Merge remote-tracking branch 'origin/master' into rnmobile/issue_331/…
mchowning Jun 4, 2020
29cf645
Enable space after mention on Android
mchowning Jun 5, 2020
297a9ba
Merge branch 'master' into rnmobile/issue_331/mention_support_trigger…
SergioEstevao Jun 10, 2020
6973e45
Remove DEV flag for toolbar mention button.
SergioEstevao Jun 12, 2020
30179ec
Merge branch 'master' into rnmobile/issue_331/mention_support_trigger…
SergioEstevao Jun 12, 2020
0c61b43
Merge branch 'rnmobile/master_2' into rnmobile/issue_331/mention_supp…
SergioEstevao Jun 19, 2020
4920c52
Merge branch 'master' into rnmobile/issue_331/mention_support_trigger…
SergioEstevao Jun 24, 2020
6b74a0d
Bring changes from gb-mobile to the monorepo structure.
SergioEstevao Jun 24, 2020
6c5e679
Check triggerKeyCodes on Android
mchowning Jun 25, 2020
31d0007
Add newline to end of file
mchowning Jun 25, 2020
75b608c
Merge branch 'master' into rnmobile/issue_331/mention_support_trigger…
SergioEstevao Jun 26, 2020
4217be8
Update code to use keycodes.
SergioEstevao Jun 29, 2020
036b7d9
Update GB main reference.
SergioEstevao Jun 29, 2020
a17dbc2
Merge branch 'master' into rnmobile/issue_331/mention_support_trigger…
SergioEstevao Jun 29, 2020
2348709
Update dependencies.
SergioEstevao Jun 29, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only trigger @ keypress on DEV builds.
  • Loading branch information
SergioEstevao committed May 8, 2020
commit 0b7631529bae281cb71c47cac97e389bb2c5db75
2 changes: 1 addition & 1 deletion packages/rich-text/src/component/index.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,7 @@ export class RichText extends Component {
onFocus={ this.onFocus }
onBlur={ this.onBlur }
onKeyDown={ this.onKeyDown }
triggerKeyCodes={ [ '@' ] }
triggerKeyCodes={ __DEV__ ? [ '@' ] : []}
onPaste={ this.onPaste }
activeFormats={ this.getActiveFormatNames( record ) }
onContentSizeChange={ this.onContentSizeChange }
Expand Down