-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rnmobile/fix font size breakage #21527
Conversation
This allow that font size attributes are still read and saved properly in mobile.
Size Change: -7 B (0%) Total Size: 903 kB
ℹ️ View Unchanged
|
👋 Sérgio! Looking at the diff it seems that the Platform selection is removed and the code is unified with the web, making this feel like there is typography support on native mobile too, but the PR description mentions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to move the check up in the tree
@hypest if you look at the diff in the |
Ah, sorry for not noticing that. This makes sense now, the check got expanded to include both font-size and line-height, thanks for updating the PR description with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Fix font size breakage that was created because mobile Gutenberg doesn't yet support editing of typography attributes.
The breakage can be seen by selecting a paragraph control and then tapping on the settings icon (cog).
Before the typography settings consisted only on the line size, but now they were expanded to have font size, and joined together in a single Panel called Typography.
This PR hides the full typography panel in RN GB-mobile instead of just the line-size attribute.
How has this been tested?
This can be tested using this PR in GB-mobile: wordpress-mobile/gutenberg-mobile#2149
Screenshots
Types of changes
Checklist: