Disable align button on the heading block for Android #21268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioEstevao
added
the
Mobile App - i.e. Android or iOS
SergioEstevao
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
Merged
2 tasks
|
Size Change: +2.12 kB (0%) Total Size: 863 kB
ℹ️ View Unchanged
|
mchowning
reviewed
Mar 30, 2020
| setAttributes( { align: nextAlign } ); | ||
| } } | ||
| /> | ||
| { Platform.OS !== 'android' && ( |
There was a problem hiding this comment.
This isn't working for me (I still see the alignment buttons on Android). I think because this is our re-exported Platform and not the react-native Platform. I'm seeing Platform.OS with a value of native. Do we have to use Platform.select here?
mchowning
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disables the align controls in the Heading block for Android.
We are disabling it because Aztec for Android is still not ready to support this functionality.
How has this been tested?
This can be tested using this GB mobile PR: wordpress-mobile/gutenberg-mobile#2084
Screenshots
Types of changes
Checklist: