Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge changes from mobile v1.24.0 to master #21041

Merged
merged 7 commits into from
Mar 23, 2020
Merged

Merge changes from mobile v1.24.0 to master #21041

merged 7 commits into from
Mar 23, 2020

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Mar 20, 2020 •
edited
Loading

Related gutenberg-mobile PR

Description

Update with changes from Mobile 1.24 release

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

marecar3 and others added 5 commits March 17, 2020 18:32
@marecar3
Disable Cover for production
bdec613
@jbinda @marecar3
apply flex to prevent caption overlap in Gallery block (#20987)
8c7612e
@SergioEstevao @marecar3
Rnmobile/fix space max2 (#20986)
210273b 
* Disable Cover for production

* Adapt max according to the current value.

Co-authored-by: Marko Savic <[email protected]>
@SergioEstevao @marecar3
Add isFileURL method and use it on all native media upload checks. (#…
d9f089b 
…20985)

* Add isFileURL method and use it on all native media upload checks.

* Check if url is defined.

* Add test for undefined and fix lint error for isFileURL

* Replace isFileURL method for getProcotol == 'file' mettod
@chipsnyder @marecar3
[RNMobile] Latest-Posts: Resolve issue with Query Controls, and fix A…
8bd203a 
…PI Fetch strategy (#21025)

* Convert the categories fetchRequest to use the apiFetch API for cacheing

* Fix Conflict in Query Controls to move the stable state to Mobile

* Fix Conflict in Query Controls to move the stable state to Mobile
@marecar3 marecar3 added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Mar 20, 2020
@marecar3 marecar3 added this to the Gutenberg 7.8 milestone Mar 20, 2020
@marecar3 marecar3 requested review from Tug and mchowning March 20, 2020 10:12
@marecar3 marecar3 mentioned this pull request Mar 20, 2020
Merged
7 tasks
@github-actions
Copy link

github-actions bot commented Mar 20, 2020 •
edited
Loading

Size Change: +37 B (0%)

Total Size: 856 kB

Filename Size Change
build/block-library/index.js 110 kB +31 B (0%)
build/edit-post/index.js 91.2 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 998 B 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 100 kB 0 B
build/block-editor/style-rtl.css 10.9 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 7.24 kB 0 B
build/block-library/editor.css 7.24 kB 0 B
build/block-library/style-rtl.css 7.41 kB 0 B
build/block-library/style.css 7.42 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.5 kB 0 B
build/components/index.js 191 kB 0 B
build/components/style-rtl.css 15.8 kB 0 B
build/components/style.css 15.7 kB 0 B
build/compose/index.js 6.21 kB 0 B
build/core-data/index.js 10.6 kB 0 B
build/data-controls/index.js 1.04 kB 0 B
build/data/index.js 8.2 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 771 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/style-rtl.css 8.47 kB 0 B
build/edit-post/style.css 8.46 kB 0 B
build/edit-site/index.js 5.56 kB 0 B
build/edit-site/style-rtl.css 2.62 kB 0 B
build/edit-site/style.css 2.62 kB 0 B
build/edit-widgets/index.js 4.43 kB 0 B
build/edit-widgets/style-rtl.css 2.58 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 381 B 0 B
build/editor/editor-styles.css 382 B 0 B
build/editor/index.js 43.8 kB 0 B
build/editor/style-rtl.css 3.97 kB 0 B
build/editor/style.css 3.96 kB 0 B
build/element/index.js 4.44 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 6.95 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.93 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.49 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.69 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.84 kB 0 B
build/notices/index.js 1.58 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 780 B 0 B
build/redux-routine/index.js 2.83 kB 0 B
build/rich-text/index.js 14.4 kB 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

Tug
Tug approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

This was referenced Mar 23, 2020
Closed
Merged
@marecar3 marecar3 merged commit 82225c6 into master Mar 23, 2020
@marecar3 marecar3 deleted the rnmobile/release-1.24.0 branch March 23, 2020 10:58
@SergioEstevao SergioEstevao mentioned this pull request Mar 31, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tug Tug Tug approved these changes

@mchowning mchowning Awaiting requested review from mchowning

@aduth aduth Awaiting requested review from aduth

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 7.8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marecar3 @Tug @jbinda @SergioEstevao @chipsnyder