[FEAT] Support linear gradient in cover block #20411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if the content has higher height
…/cover-block # Conflicts: # packages/block-editor/src/components/media-upload/index.native.js # packages/block-library/src/heading/edit.native.js # packages/block-library/src/paragraph/edit.native.js # packages/rich-text/src/component/index.native.js
…h mobile and renaming to attributesFromMedia
…d prettier formatting
…/cover-block # Conflicts: # packages/rich-text/src/component/index.native.js
…med onlyMediaLibrary to __experimental
…/cover-block # Conflicts: # packages/block-editor/src/components/media-upload/index.native.js # packages/components/src/index.native.js
… solid background
2 tasks
dratwas
added
the
Mobile App - i.e. Android or iOS
…/cover-block # Conflicts: # packages/block-editor/src/components/media-upload/index.native.js # packages/block-library/src/index.native.js
|
Size Change: 0 B Total Size: 865 kB ℹ️ View Unchanged
|
geriux
approved these changes
Feb 26, 2020
|
The base branch has been updated :). I also added one test case to check if we have correct settings when the gradient is set |
|
Let's update the PR description to refer to wordpress-mobile/gutenberg-mobile#1860 instead. My bad directing to the wrong issue in the first place. |
All working great! Thanks!! Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wordpress-mobile/gutenberg-mobile#1860
Gutenberg-mobile PR - wordpress-mobile/gutenberg-mobile#1949
ATM we are able to set the linear gradient as a background in the cover block. Since we don't have the gradient picker on mobile yet I added a possibility to render linear-gradient if it set on the web.
Additionally, I moved the logic from ColorBackground related to the gradient to a separate file - LinearGradient.
How has this been tested?
Test case 1
Test case 2
Test case 3
BlockToolbar and choose media to set an image as a backgroundTest case 4
Screenshots
Types of changes
Checklist: