Create block: Add check for minimum system requirements #20398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added error message when minimum system requirements not met. Corrected the minimum `npm` version required to align with `@wordpress/scripts` package used internally.
gziolo
added
[Package] Create Block
|
Size Change: 0 B Total Size: 864 kB ℹ️ View Unchanged
|
|
@jorgefilipecosta – do you think we can include this simple bug fix/improvement in the Beta 3/npm release? |
jorgefilipecosta
added
the
Backport to WP 6.6 Beta/RC
jorgefilipecosta
approved these changes
Feb 24, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Feb 24, 2020
* Create block: Add check for minimum system requirements Added error message when minimum system requirements not met. Corrected the minimum `npm` version required to align with `@wordpress/scripts` package used internally. * Update CHANGELOG.md
jorgefilipecosta
pushed a commit
that referenced
this pull request
Feb 24, 2020
* Create block: Add check for minimum system requirements Added error message when minimum system requirements not met. Corrected the minimum `npm` version required to align with `@wordpress/scripts` package used internally. * Update CHANGELOG.md
jorgefilipecosta
removed
the
Backport to WP 6.6 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20142.
This PR adds error message when minimum system requirements not met. It also include the change that corrected the minimum
npmversion required to align with@wordpress/scriptspackage used internally.How has this been tested?
npx wp-create-blockshould still work as expected.If the minimum required version for
nodeornpmis not met, the following error is going to be printed on the console:I manually tweaked the version in
package.jsonfile of@wordpress/create-blockpackage. It can be also tested by downgradingnodeornpm.Types of changes
Bug fix (non-breaking change which fixes an issue).
Checklist: