Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Icons: Add missing icon #20281

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Social Icons: Add missing icon #20281

merged 1 commit into from
Feb 18, 2020

Conversation

mcsf
Copy link
Contributor

@mcsf mcsf commented Feb 18, 2020

Description

Addresses report from Slack by @gziolo.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@mcsf mcsf added the [Block] Social Affects the Social Block - used to display Social Media accounts label Feb 18, 2020
@mcsf mcsf requested a review from mkaz as a code owner February 18, 2020 11:16
@mcsf mcsf added this to Needs Review in WordPress 5.4 Must Have Feb 18, 2020
gziolo
gziolo approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me :)

@mcsf mcsf merged commit 322da29 into master Feb 18, 2020
WordPress 5.4 Must Have automation moved this from Needs Review to Done Feb 18, 2020
@mcsf mcsf deleted the update/social-icons-and-descriptions branch February 18, 2020 15:24
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 18, 2020
@jorgefilipecosta jorgefilipecosta added the Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 18, 2020
jorgefilipecosta pushed a commit that referenced this pull request Feb 24, 2020
@mcsf @jorgefilipecosta
Social Icons: Add missing icon. Edit description. (#20281)
daaf3c7
@jorgefilipecosta jorgefilipecosta mentioned this pull request Feb 24, 2020
Merged
jorgefilipecosta pushed a commit that referenced this pull request Feb 24, 2020
@mcsf @jorgefilipecosta
Social Icons: Add missing icon. Edit description. (#20281)
8c464f4
@jorgefilipecosta jorgefilipecosta removed the Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@mkaz mkaz Awaiting requested review from mkaz

Assignees
No one assigned
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts
Projects
No open projects
WordPress 5.4 Must Have
  
Done
Milestone
Gutenberg 7.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcsf @gziolo @jorgefilipecosta