Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template Loader: Localize empty template message. #20277

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Template Loader: Localize empty template message. #20277

merged 1 commit into from
Feb 18, 2020

Conversation

epiqueras
Copy link
Contributor

@epiqueras epiqueras added this to the Gutenberg 7.6 milestone Feb 17, 2020
@epiqueras epiqueras self-assigned this Feb 17, 2020
@epiqueras epiqueras mentioned this pull request Feb 17, 2020
Merged
6 tasks
noahtallen
noahtallen approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@noahtallen noahtallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Not much to look at :)

@epiqueras epiqueras force-pushed the fix/localize-empty-template-message branch from b575ad5 to 0db7f5b Compare February 18, 2020 06:05
@epiqueras epiqueras merged commit c76137b into master Feb 18, 2020
@epiqueras epiqueras deleted the fix/localize-empty-template-message branch February 18, 2020 06:22
@mtias
Copy link
Member

mtias commented Feb 18, 2020

I had assumed this was just placeholder content for now?

@epiqueras
Copy link
Contributor Author

Yeah, but is it wrong to localize it?

@mtias
Copy link
Member

mtias commented Feb 18, 2020

Not wrong, but should be generally unnecessary with very work-in-progress things as it'd trigger folks to waste some effort translating text that is ephemeral.

@epiqueras
Copy link
Contributor Author

I suspected that. Should we revert this?

@mtias
Copy link
Member

mtias commented Feb 21, 2020

No need to :)

@ellatrix ellatrix mentioned this pull request Jun 16, 2020
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahtallen noahtallen noahtallen approved these changes

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees

@epiqueras epiqueras

Labels
None yet
Projects
None yet
Milestone
Gutenberg 7.6
Development

Successfully merging this pull request may close these issues.
3 participants
@epiqueras @mtias @noahtallen