Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Fix item width inside Inserter #20238

Merged
merged 3 commits into from
Feb 17, 2020
Merged

[RNMobile] Fix item width inside Inserter #20238

merged 3 commits into from
Feb 17, 2020

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Feb 14, 2020 •
edited
Loading

Description

Fixes:

Ref to gutenberg-mobile: wordpress-mobile/gutenberg-mobile#1914

How has this been tested?

  1. Change device font size to the largest
  2. Change display zoom to max (if available)
  3. Open the app
  4. Press the inserter
  5. Observe if all the items are displayed properly within a grid

Screenshots

  • IOS - observe the long block name as well
default font size the largest font size
Screenshot 2020-02-14 at 14 48 41 Screenshot 2020-02-14 at 14 49 43
default font size the largest font size
Screenshot 2020-02-14 at 14 51 03 Screenshot 2020-02-14 at 14 50 35
  • Android
default font size the largest font size + zoom
Screenshot 2020-02-14 at 14 54 28 Screenshot 2020-02-14 at 14 53 23
default font size the largest font size + zoom
Screenshot 2020-02-14 at 14 59 15 Screenshot 2020-02-14 at 14 52 55

Types of changes

Set the width on modal item.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@lukewalczak lukewalczak self-assigned this Feb 14, 2020
@lukewalczak lukewalczak added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Feb 14, 2020
@lukewalczak lukewalczak mentioned this pull request Feb 14, 2020
Merged
2 tasks
etoledom
etoledom approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great solving the related issues! Thank you @lukewalczak 🎉

packages/components/src/mobile/bottom-sheet/index.native.js
Comment on lines +115 to +116
const statusBarHeight =
Platform.OS === 'android' ? StatusBar.currentHeight : 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

@lukewalczak lukewalczak merged commit 5870caf into master Feb 17, 2020
@lukewalczak lukewalczak deleted the rnmobile/patch-bottom-sheet branch February 17, 2020 13:35
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 17, 2020
@lukewalczak lukewalczak mentioned this pull request Oct 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

Assignees

@lukewalczak lukewalczak

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 7.6
Development

Successfully merging this pull request may close these issues.
2 participants
@lukewalczak @etoledom