Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move another batch of dashicons to the icons package #20234

Merged
merged 3 commits into from
Feb 17, 2020
Merged

Move another batch of dashicons to the icons package #20234

merged 3 commits into from
Feb 17, 2020

Conversation

youknowriad
Copy link
Contributor

New icons:

  • backup
  • brush (admin-customizer)
  • block (block-default)
  • chartLine
  • closeCircleFilled (dismiss)
  • cloudUpload
  • cloud
  • grid (screenoptions)
  • informationOutline (info-outline)
  • keyboardClose (keyboard-hide)
  • plus
  • pin (admin-post)
  • page (admin-page)
  • minus
  • sphere (admin-site-alt3)
  • tableEdit (editor-table)

@youknowriad youknowriad self-assigned this Feb 14, 2020
@youknowriad youknowriad added the [Type] Code Quality Issues or PRs that relate to code quality label Feb 14, 2020
@jasmussen
Copy link
Contributor

Left a couple of small notes. To clarify the last one, "info" seems to be more universally used than the more verbose "information", so let's keep it short and sweet!

With the changes made, this is 👍 👍

@youknowriad youknowriad merged commit 102e8b5 into master Feb 17, 2020
@youknowriad youknowriad deleted the update/another-dashicons-batch branch February 17, 2020 13:15
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 17, 2020
@simison simison mentioned this pull request May 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtias mtias mtias left review comments

@jasmussen jasmussen jasmussen left review comments

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@ellatrix ellatrix Awaiting requested review from ellatrix

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees

@youknowriad youknowriad

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 7.6
Development

Successfully merging this pull request may close these issues.
3 participants
@youknowriad @jasmussen @mtias