Navigation: rename background color CSS class #20018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames the CSS class from
has-background-color
tohas-background
when it defines a background color of the Navigation menu since, in general and by convention,has-background-color
makes a reference to a color namedbackground
, in the same way thathas-foreground-light-background-color
,has-primary-background-color
, ... does.So the correct CSS class name to apply is
has-background
.How has this been tested?
It has been tested with
Maywood
theme.before
Confirm that the text color is not visualized either in the editor-canvas as well as in the front-end.
after
Confirm that the text color is rightly applied on both sides.
Screenshots
Types of changes
Checklist: