Linting Documentation #19543
Merged
Linting Documentation #19543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaz
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
gziolo
approved these changes
Jan 10, 2020
ntwb
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A first pass on seeing what errors the new
npm run lint-mdcommand introduces with #19518The commas, quotes, and whitespace all seem to be accurate lint issues.
One issue is the mix of ES5 code and ESNext together, the function and variable definitions don't match the lint rules, for example using
varinstead of `let.How has this been tested?
Run
npm run lint-mdto see recommendationsThis PR reduces the issues on a small set of files
Types of changes
Documentation lint changes.