Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: FontSizePicker: Adjust Select Button sizing #19479

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Components: FontSizePicker: Adjust Select Button sizing #19479

merged 3 commits into from
Jan 29, 2020
+12 −10

Commits on Jan 29, 2020

  1. Components: FontSizePicker: Adjust Select Button sizing 

    This update enhances `CustomSelectControl` to accept props to modify it's
internal `Button` component (`Object`). Since `FontSizePicker` uses
`CustomSelectControl`, this update allows us to specify the `isSmall`
property for the `Button`. By doing so, it fixes the alignment of the Select
with the other form control elements.
    @youknowriad
    Jon Q authored and youknowriad committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    6a30654 View commit details
    Browse the repository at this point in the history

  2. Remove buttonProps. Add isSmall as default for CustomSelectControl.

    @youknowriad
    Jon Q authored and youknowriad committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    f55084f View commit details
    Browse the repository at this point in the history

  3. Fix unit tests and remove isSmall prop

    @youknowriad
    youknowriad committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    67f13d2 View commit details
    Browse the repository at this point in the history