Consolidate web/native BlockEditorProvider #19120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this one, since the changes were merged in #19106. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a native variant of
BlockEditorProvider, introduced in #14375 (although having that generic PR squashed doesn't help figure out why)As part of wordpress-mobile/gutenberg-mobile#1466, I'm implementing
BlockPreview(or a variant of it) on native, which requires us to be able to have more than one provider at once. The newer web version seems to be using a subregistry to handle this.I haven't found anything that looks mobile specific, so in this PR I've just copied the web version into the native file, so it's easier to diff, but before merging I would just delete the native file.
How has this been tested?
I did some basic testing inserting, moving, deleting blocks, typing, changing selection... Everything seems to work fine, but I'm not sure if there's anything else we should be testing
Checklist: