Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modal component usage example code #18452

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Fix modal component usage example code #18452

merged 1 commit into from
Nov 12, 2019

Conversation

ediamin
Copy link
Contributor

@ediamin ediamin commented Nov 12, 2019

Description

This PR fixes some issues relate to the example usage code for Modal component.

Issues

  • import useState from @wordpress/compose, which should be @wordpress/element.
  • There are two lines contain { closeModal ) } that contains extra close parenthesis.

Types of changes

  • import useState from @wordpress/element
  • remove extra close parenthesis

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.

@Soean Soean added the [Type] Developer Documentation Documentation for developers label Nov 12, 2019
Soean
Soean approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@Soean Soean merged commit 133db23 into WordPress:master Nov 12, 2019
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soean Soean Soean approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ediamin @Soean @youknowriad