Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Cloud: Remove strtolower around taxonomy name #16112

Merged
merged 7 commits into from
Sep 27, 2022

Conversation

Soean
Copy link
Member

@Soean Soean commented Jun 12, 2019

Description

Bildschirmfoto 2019-06-12 um 11 57 32

In German we have Kategorien (categories) and Schlagwörter (tags). The first letter needs to be uppercase.

@Soean Soean added the [Block] Tag Cloud Affects the Tag Cloud Block label Jun 12, 2019
@Soean Soean requested a review from melchoyce June 12, 2019 10:05
@Soean Soean self-assigned this Jun 12, 2019
@Soean Soean added the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Jun 12, 2019
@Soean
Copy link
Member Author

Soean commented Jun 12, 2019

I added the copy review label:
Is it okay to use the uppercase Tags instead of tags?
Your sites doesn’t have any Tags, so there’s nothing to display here at the moment.

@michelleweber
Copy link

Hmm. That doesn't really work in English; "tags" isn't a word that would be capitalized except in a headline/title.

@Soean
Copy link
Member Author

Soean commented Jun 12, 2019

Thanks for your feedback. So we have to change the sentence.

@aduth
Copy link
Member

aduth commented Jun 12, 2019

Thanks for your feedback. So we have to change the sentence.

Are you aware of any prior art for how these issues have been dealt with in the past, as a general point of localization best practices? I'd wonder if in the worst case it might be reasonable to have logic to switch on the locale in deciding the appropriate treatment for the word.

@ocean90
Copy link
Member

ocean90 commented Jun 12, 2019

Have you thought about using a more generic string instead?

Your site doesn't have any items in the selected taxonomy, so there's nothing to display here at the moment.

Otherwise see get_post_type_labels() and get_taxonomy_labels(). Both can be used to define new labels which depend on the post type/taxonomy name.

@melchoyce
Copy link
Contributor

I'd like to avoid using words like "taxonomy" if we can, since it's a pretty technical word.

@ocean90
Copy link
Member

ocean90 commented Jun 12, 2019

But it's something the user has selected in the block settings, see

<SelectControl
label={ __( 'Taxonomy' ) }
options={ taxonomyOptions }
value={ taxonomy }
onChange={ this.setTaxonomy }
/>
.

@melchoyce
Copy link
Contributor

Yeah, I mean tbh I'd love to find a better way to write that, too.

@melchoyce
Copy link
Contributor

@michelleweber How do you feel about @ocean90's suggestion? I might just be overthinking this.

@ocean90
Copy link
Member

ocean90 commented Jun 12, 2019

Not sure about the label of the select field but here are some other ideas:

With the current settings there’s nothing to display here at the moment.

There’s no content that matches your selection, yet.

@michelleweber
Copy link

I'd definitely like to avoid using the word "taxonomy." We could definitely go general with something like "There's no content to show here yet," but if there's a way to include specific messaging that both explains and nudges the user toward a next step/way to resolve, that would be far, far preferable.

@Soean
Copy link
Member Author

Soean commented Jul 2, 2019

Thanks for the Feedback, I updated the text to: There's no content to show here yet.. This is translatable in all languages and doesn't include the word 'taxonomy'.

@Soean Soean added Needs Copy Review Needs review of user-facing copy (language, phrasing) and removed Needs Copy Review Needs review of user-facing copy (language, phrasing) labels Jul 12, 2019
@michelleweber
Copy link

"No content to show yet" is fine, but it would be really great if, as @aduth suggests, we figure out ways to fine-tune localization. Ideally we're describing things as clearly as possible, and in this case, that means using the word "tags."

@swissspidy
Copy link
Member

Well the only way to do that is by extending the list of available taxonomy labels, as mentioned earlier in this thread. See get_taxonomy_labels() in core.

So just like we have labels like Add New Tag and Add New Category, there would need to be new labels Your site doesn't have any tags, so there’s nothing to display here at the moment. / Your site doesn't have any categories, so there’s nothing to display here at the moment.

I'm not sure if it's really worth it to add such a new label for this specific use area.

packages/block-library/src/tag-cloud/index.php Outdated Show resolved Hide resolved
Base automatically changed from master to trunk March 1, 2021 15:42
@Mamaduka
Copy link
Member

Hi, @Soean

Can you rebase the branch? I think we can merge this after #16112 (comment) is addressed.

@Soean
Copy link
Member Author

Soean commented Sep 26, 2022

@Mamaduka thanks, I rebased the branch.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. and removed Needs Copy Review Needs review of user-facing copy (language, phrasing) labels Sep 27, 2022
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up, @Soean 🙇

@Mamaduka Mamaduka dismissed ocean90’s stale review September 27, 2022 05:53

The feedback was addressed.

@Mamaduka Mamaduka merged commit fa55970 into trunk Sep 27, 2022
@Mamaduka Mamaduka deleted the update/tag-cloud-error-message branch September 27, 2022 05:53
@github-actions github-actions bot added this to the Gutenberg 14.3 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Tag Cloud Affects the Tag Cloud Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants