-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag Cloud: Remove strtolower
around taxonomy name
#16112
Conversation
I added the copy review label: |
Hmm. That doesn't really work in English; "tags" isn't a word that would be capitalized except in a headline/title. |
Thanks for your feedback. So we have to change the sentence. |
Are you aware of any prior art for how these issues have been dealt with in the past, as a general point of localization best practices? I'd wonder if in the worst case it might be reasonable to have logic to switch on the locale in deciding the appropriate treatment for the word. |
Have you thought about using a more generic string instead?
Otherwise see |
I'd like to avoid using words like "taxonomy" if we can, since it's a pretty technical word. |
But it's something the user has selected in the block settings, see gutenberg/packages/block-library/src/tag-cloud/edit.js Lines 69 to 74 in 39f568f
|
Yeah, I mean tbh I'd love to find a better way to write that, too. |
@michelleweber How do you feel about @ocean90's suggestion? I might just be overthinking this. |
Not sure about the label of the select field but here are some other ideas:
|
I'd definitely like to avoid using the word "taxonomy." We could definitely go general with something like "There's no content to show here yet," but if there's a way to include specific messaging that both explains and nudges the user toward a next step/way to resolve, that would be far, far preferable. |
Thanks for the Feedback, I updated the text to: |
"No content to show yet" is fine, but it would be really great if, as @aduth suggests, we figure out ways to fine-tune localization. Ideally we're describing things as clearly as possible, and in this case, that means using the word "tags." |
Well the only way to do that is by extending the list of available taxonomy labels, as mentioned earlier in this thread. See So just like we have labels like I'm not sure if it's really worth it to add such a new label for this specific use area. |
Hi, @Soean Can you rebase the branch? I think we can merge this after #16112 (comment) is addressed. |
Co-authored-by: Dominik Schilling <[email protected]>
…/gutenberg into update/tag-cloud-error-message
@Mamaduka thanks, I rebased the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-up, @Soean 🙇
Description
In German we have
Kategorien
(categories) andSchlagwörter
(tags). The first letter needs to be uppercase.