Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if onFocus is not undefined before calling it #14967

Merged
merged 3 commits into from
Apr 12, 2019
Merged

Check if onFocus is not undefined before calling it #14967

merged 3 commits into from
Apr 12, 2019

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 added the Mobile Web Viewport sizes for mobile and tablet devices label Apr 12, 2019
@marecar3 marecar3 requested review from mzorz and etoledom April 12, 2019 20:02
@marecar3 marecar3 self-assigned this Apr 12, 2019
@marecar3 marecar3 mentioned this pull request Apr 12, 2019
Merged
mzorz
mzorz approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marecar3 marecar3 merged commit 85edc75 into master Apr 12, 2019
@marecar3 marecar3 deleted the rnmobile/865-on_focus_can_be_sometimes_unefined_on_iOS branch April 12, 2019 22:31
@etoledom
Copy link
Contributor

Just to complement:
The real cause of the error is covered here: #14969
This PR just silence the error.

Still good to guard the prop call before calling it ✅
Thank you @marecar3

mchowning pushed a commit to mchowning/gutenberg that referenced this pull request Apr 15, 2019
@marecar3 @mchowning
Check if onFocus is not undefined before calling it (WordPress#14967)
4654f19 
* Check if onFocus is not undefined before calling it
@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 15, 2019
@gziolo gziolo added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) and removed Mobile Web Viewport sizes for mobile and tablet devices labels Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzorz mzorz mzorz approved these changes

@etoledom etoledom Awaiting requested review from etoledom

Assignees

@marecar3 marecar3

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
5.5 (Gutenberg)
Development

Successfully merging this pull request may close these issues.

Post Title can't be re-focused after focus has changed
5 participants
@marecar3 @etoledom @mzorz @youknowriad @gziolo