[RNMobile] Temporarily disable link formatting for alpha #13036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tug
reviewed
Dec 20, 2018
| title: __( 'Link' ), | ||
| format: 'link', | ||
| }, | ||
| // TODO: get this back after alpha |
There was a problem hiding this comment.
I think we can remove the code, we use a VCS after all :)
There was a problem hiding this comment.
heh ofc, the thing is given this is a last minute thing and we'll need it back to continue work after alpha, it makes sense to keep it calling our attention "on the foreground" :)
|
Code LGTM 👍 |
youknowriad
pushed a commit
that referenced
this pull request
Jan 9, 2019
youknowriad
pushed a commit
that referenced
this pull request
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Temporarily removes the
linktext formatting button from mobile GutenbergHow has this been tested?
Run the demo app, verify the link option is not displayed anymore when tapping into a Paragraph block and selecting a word
Screenshots
Before
After
Types of changes
Hides a feature
Checklist: