Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: add e2e test for the HTML block #12550

Merged
merged 3 commits into from
Dec 5, 2018
Merged

Testing: add e2e test for the HTML block #12550

merged 3 commits into from
Dec 5, 2018

Conversation

designsimply
Copy link
Member

@designsimply designsimply commented Dec 3, 2018 •
edited
Loading

Description

This PR adds a basic test for the Custom HTML block.

How has this been tested?

npm run test-e2e

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Block] HTML Affects the the HTML Block labels Dec 3, 2018
tofumatt
tofumatt approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@tofumatt tofumatt added this to the 4.7 milestone Dec 3, 2018
gziolo
gziolo approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

As far as I remember Pythagorean theorem looks legit 😄

@gziolo
Copy link
Member

gziolo commented Dec 4, 2018

@designsimply, you should also open a follow-up PR and add yourself to https://github.com/WordPress/gutenberg/blob/master/CONTRIBUTORS.md :)

@tofumatt
Copy link
Member

tofumatt commented Dec 5, 2018

Since this is just a test change I'm going to merge it in now as there's no harm in extra tests and it'll lighten the PR count 😅

@tofumatt tofumatt merged commit 8743217 into master Dec 5, 2018
@tofumatt tofumatt deleted the add/e2e-html-block branch December 5, 2018 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tofumatt tofumatt tofumatt approved these changes

@gziolo gziolo gziolo approved these changes

Assignees
No one assigned
Labels
[Block] HTML Affects the the HTML Block [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
4.7
Development

Successfully merging this pull request may close these issues.
3 participants
@designsimply @gziolo @tofumatt