Make undo action update blockSelection #12133
Conversation
oandregal
changed the title
oandregal
added
[Type] Bug
| * | ||
| * @return {Object} Updated state. | ||
| */ | ||
| export const blockSelection = withHistory()( rawBlockSelection ); |
There was a problem hiding this comment.
I don't get why this isn't part of the same history reducer as blocks.
There was a problem hiding this comment.
You mean part of core/editor.editor reducer? As I was thinking through this PR I was starting to feel that would be the only approach that makes sense long-term - it is the only that keeps editor state and block selection in sync.
There was a problem hiding this comment.
Also against this PR: I worry that adding history to the blockSelection makes the state grow bigger than desired. And that we can have multiple consecutive entries for the same block (for ex: click a block adds an entry, then select a range within the block adds another entry, then click within the block adds another entry) is problematic.
This PR makes the
blockSelectionreducer history aware.Fixes #12002
Alternative to #12052