Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN mobile] pass isSelected to RichText components #11857

Merged
merged 5 commits into from
Nov 15, 2018

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Nov 14, 2018

Description

This PR passes the isSelected prop down to the implementation of RichText components to make them respond to focus changes accordingly. This PR is tested in conjunction with wordpress-mobile/gutenberg-mobile#237

Screenshots

focus_insert2

Types of changes

New feature (non-breaking change which adds functionality)

To test:

  • Please follow instructions in related Mobile Gutenberg PR repo.

@mzorz mzorz added Mobile Web Viewport sizes for mobile and tablet devices Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Nov 14, 2018
Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mzorz mzorz merged commit db84d19 into master Nov 15, 2018
@mzorz mzorz deleted the rnmobile/is-selected-rich-text branch November 15, 2018 11:40
@gziolo gziolo removed the Mobile Web Viewport sizes for mobile and tablet devices label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants