-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganise documentation #11817
Reorganise documentation #11817
Conversation
So far this PR only moves files; I will be reorganising within files next, and hope to have this merge-ready ASAP as it's a big change that will impact a lot of things. |
Todo:
|
I’m going to write a small manifest generator tomorrow (probably based on the one WP-CLI uses) so we can get those references updated, then do a final pass at internal links. I think we will have a first version ready for tomorrow afternoon, and I’ll file iterative PRs from there. Really keen to get this first pass done and merged quickly to avoid any messy rebases/merges since it’s a fairly wide reaching PR 😅 |
working on updating structure for developer docs per discussion on #11251 |
Cross-posting from Slack:
|
Hey @0aveRyan anything I can do to help you? Do you want me to take back over? |
29cc878
to
933221b
Compare
Okay this is painfully close to being ready! Just need to get the manifest updated and we're good to go. |
285862f
to
b589430
Compare
Okay I would love many sanity checks on this but I believe this is in a good place now. As part of the re-org, I added a new file, Note: I included a (This will be followed up by new documentation—especially user documentation—that I've been working on.) |
docs/generate.php
Outdated
@@ -0,0 +1,131 @@ | |||
<?php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a script to generate docs in docs/tool
I think we should consolidate. Having two tools to generate the same documentation is weird.
Also about the new toc.json
file. I'm fine with the new file but this makes the root-manifest.json
file useless as it's generated and then used to generate manifest.json
. We should just generate manifest.json
directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree - I plan to remove my PHP script before this is merged. I am time constrained right now so I decided to write it in a language that I was a little more familiar to me so I could get it done faster :)
Co-Authored-By: chrisvanpatten <[email protected]>
…into big/reorganise-docs
...developers/developers/tutorials/block-tutorial/introducing-attributes-and-editable-fields.md
Outdated
Show resolved
Hide resolved
Managing relative links in this base is definitely one of the biggest challenges for docs. I can't confidently review them all, but as you've noticed there's quite a few that may be broken. That said, if you're overall confident that we can iterate on that, I can 👍 this PR! |
@mcsf I would love to figure out some kind of system that would remove the need to use relative links. If anyone out there has any clever ideas I'm all ears! |
🎉 |
## Description Following on from #12411 and #11817 it was noticed that some pages were skipped, as they weren't included in the `toc.json` file previously. This PR includes several specific fixes which are all interconnected: 1. Adds the Internationalization page along with the Block Tutorial to the handbook hierarchy 1. An additional landing page for the Tutorials index was added 1. `Components` was added to the developers handbook alongside `Packages` and `Data Package Reference` pages. 1. In order to handle the above move, the duplicative declarations of `Packages`, `Data Package Reference` and `Components` were removed from `docs/tool/manifest.js` to prevent them adding as top-level-items. (Are these intended to be top-level-handbook-pages or deep within the developers handbook as the TOC seems to suggest?) I also took the opportunity to convert `generate.php` from the previous PR into a JS command that allows for `docs/root-manifest.json` to be removed entirely and dynamically generated from `docs/toc.json` so it only needs updating in a single location. That's the `getRootManifest()` and `generateRootManifestFromTOCItems()` functions which are rather messy, but work (I'm sure someone else could clean that up significantly). ## How has this been tested? The only testing done so far is the manual review of the final `docs/manifest.json`.
This is the long-awaited reorganisation of documentation into three handbooks:
This is NOT READY FOR MERGE OR REVIEW.I hope this is ready to go… or close :)Thank you ❤️